Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address compile warnings #87

Open
jcs090218 opened this issue Sep 3, 2020 · 6 comments
Open

Address compile warnings #87

jcs090218 opened this issue Sep 3, 2020 · 6 comments
Labels

Comments

@jcs090218
Copy link
Collaborator

I'm getting these warnings when installing this package. Maybe you want to fix it?

Thanks!

In end of data:
gdscript-hydra.el:157:1:Warning: the function `gdscript-hydra--menu/body' is
    not known to be defined.

In gdscript-info-dedenter-opening-block-positions:
gdscript-indent-and-nav.el:755:24:Warning: `seq-contains' is an obsolete
    function (as of 27.1); use `seq-contains-p' instead.

In gdscript-project--select-scene:
gdscript-project.el:52:111:Warning: `format' called with 1 args to fill 0
    format field(s)

In end of data:
gdscript-project.el:115:1:Warning: the function `ag-project-regexp' is not
    known to be defined.
@Calinou Calinou added the enhancement New feature or request label Sep 3, 2020
@NathanLovato NathanLovato added refactor and removed enhancement New feature or request labels Sep 3, 2020
@NathanLovato
Copy link
Collaborator

Weird, makem.sh test doesn't report any error.

seq-contains is normal, we support Emacs 26.3, where seq-contains-p isn't available if I remember right.

The others definitely could use some cleanup.

@jcs090218
Copy link
Collaborator Author

I am using Emacs 27.1 on Windows.

@NathanLovato
Copy link
Collaborator

You were fast! While you were commenting, I removed the initial comment and wrote another.

@NathanLovato NathanLovato added the good first issue Good for newcomers label Sep 3, 2020
@NathanLovato NathanLovato changed the title Compile log warnings. Address compile warnings Sep 3, 2020
@NathanLovato
Copy link
Collaborator

After running tests locally, we should keep in mind that some functions will always cause linting errors but those are fine, like functions relying on ag or projectile. In the code, we check that the user has the optional package before calling into it.

So the lint warnings to address are these two:

In end of data:
gdscript-hydra.el:157:1:Warning: the function `gdscript-hydra--menu/body' is
    not known to be defined.

In gdscript-project--select-scene:
gdscript-project.el:52:111:Warning: `format' called with 1 args to fill 0
    format field(s)

@jcs090218
Copy link
Collaborator Author

I have added the CI in #113. You should able to see warnings here.

@jcs090218
Copy link
Collaborator Author

Just to post some information about makem.sh.

Weird, makem.sh test doesn't report any error.

By read the documentation from their README, it seems like it would only test the package with different linters (package-lint, elsa, etc). Some errors/warnings would only appear in packaging or installing stage, so it's better if you use Cask/Eask in this scenario.

Hope the information helps! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants