Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve detection of Regex module #11407

Open
YYF233333 opened this issue Dec 22, 2024 · 0 comments · May be fixed by godotengine/godot#100751
Open

Improve detection of Regex module #11407

YYF233333 opened this issue Dec 22, 2024 · 0 comments · May be fixed by godotengine/godot#100751

Comments

@YYF233333
Copy link

Describe the project you are working on

Godot

Describe the problem or limitation you are having in your project

I'm currently seeking to improve godot build/rebuild time. Inspired by godotengine/godot#100023, I checked files include modules/modules_enabled.gen.h and find a large portion of them are checking whether the Regex module is enabled.
Including modules/modules_enabled.gen.h in files outside of modules/ folder is not a natural dependency order and will trigger unnecessary recompile, we should avoid this as much as possible.

Describe the feature / enhancement and how it helps to overcome the problem or limitation

A simple solution would be include regex in core since it has been used widely in the engine. The downside is the size of minimal template goes up by ~300K, should ask people exporting to web if this is acceptable.

An alternative solution is to force enabling Regex module for editor and dev build. They should not be so size sensitive. Also regex presents in many editor features, without it the editor is likely half-broken.

This can remove most checks except:

Includes in cpp files will not trigger cascade recompile so they are fine to go with.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

As above.

If this enhancement will not be used often, can it be worked around with a few lines of script?

It is about godot build system.

Is there a reason why this should be core and not an add-on in the asset library?

It is about godot build system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants