Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapper indexes, jinja templating and travis matrix #36

Open
johanneskoester opened this issue May 19, 2018 · 3 comments
Open

Mapper indexes, jinja templating and travis matrix #36

johanneskoester opened this issue May 19, 2018 · 3 comments

Comments

@johanneskoester
Copy link

johanneskoester commented May 19, 2018

Hey guys,
I have just thought a bit about the mapper index recipes. I think we should define them like this:

meta.yaml

package:
  name: "bwa-index-{{ GENOME_BUILD }}"
  version: "1.0.0"

build:
  noarch: generic

requirements:
  host:
    - bwa
    - {{ GENOME_BUILD }}-sequence
  run:
    - bwa

build.sh

bwa index $ggd_hg38_sequence

conda_build_config.yaml

bwa:
  - 0.7
  - 0.6
pin_run_as_build:
    bwa:
      max_pin: x.x

The last file (a conda build 3 feature, allows to automatically build for different BWA versions and it would pin the index package to the correct version, such that people can not run into the situation where they have an index that does not match the BWA version.

Finally, if we add GENOME_BUILD as a matrix to .travis.yml, we get builds for all the different genomes for free:

env:
  matrix:
    - GENOME_BUILD=hg38
    - GENOME_BUILD=hg19
    - GENOME_BUILD=mm10

This will also help a lot to reduce some redundancy here (because we don't necessary need special recipes for all genomes.
In line with this, I also suggest that the tree is extended by recipes/generic. Above bwa-index recipe would then sit in recipes/generic/bwa-index and automatically yield packages like bwa-index-hg38, and bwa-index-mm10, while each is build for both bwa 0.6 and 0.7. All with just one recipe to maintain.

@johanneskoester johanneskoester changed the title Mapper indexes Mapper indexes, jinja templating and travis matrix May 19, 2018
@arq5x
Copy link
Contributor

arq5x commented Jun 4, 2018

This seems reasonable to me. Any feedback, @mikecormier @jbelyeu @brentp ?

@jbelyeu
Copy link
Contributor

jbelyeu commented Jun 4, 2018

I believe Mike is actually planning to implement this as soon as he gets some bugs ironed out of the test integration. It does look like a good idea to me for simplification of the structure.

@apeltzer
Copy link

apeltzer commented Jun 4, 2018

Looks reasonable to me too - great that you're working on it! Happy to test things if there is need! @jbelyeu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants