Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Website] Text being cutoff #542

Open
amands98 opened this issue Feb 26, 2024 · 6 comments
Open

[Website] Text being cutoff #542

amands98 opened this issue Feb 26, 2024 · 6 comments

Comments

@amands98
Copy link

Description

The text on the harbor website is being cut off.

Location - https://goharbor.io/docs/2.4.0/build-customize-contribute/registry-landscape/

Screenshots ->

image

@sergioarmgpl
Copy link

Let me work on it @amands98

@sergioarmgpl
Copy link

I have a question, I have an option to set the table with custom styles, or maybe to configure the style that all the tables use by default what do you prefer? @OrlinVasilev

@OrlinVasilev
Copy link
Member

I prefer a common way for all tables, so we minimize the risk of forgeting to customize in the future :)
@sergioarmgpl I know we have discussed it , but can you open PR for that ?
Thank you!

@sergioarmgpl
Copy link

I will open the PR later today @OrlinVasilev

@sergioarmgpl
Copy link

sergioarmgpl commented Oct 30, 2024

This is the PR @OrlinVasilev #587

@sergioarmgpl
Copy link

The improvements for this PR is that the information is more readable with the scroll bar, here is the comparison
Before it looked like this:

Screenshot 2024-11-05 at 15 33 51

After adding a default CSS style that adds an horizontal scroll bar if necessary it will look like this:

At the Top
Screenshot 2024-11-05 at 15 35 10

At the Bottom
Screenshot 2024-11-05 at 15 34 37

There are a lot of tables that have the same problem, so I added a CSS to all the tables, so all the tables will be fixed about this issue, a similar approach is currently used for CLI commands:
Screenshot 2024-11-05 at 15 39 59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants