Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for MD4 and MD5 #105

Merged
merged 5 commits into from
Aug 31, 2023
Merged

Support for MD4 and MD5 #105

merged 5 commits into from
Aug 31, 2023

Conversation

qmuntal
Copy link
Collaborator

@qmuntal qmuntal commented Aug 16, 2023

  • MD4 will be used in x/crypto/md4.
    Always available in OpenSSL 1, but in OpenSSL it os available in the legacy provider.
  • MD5 will be used in crypto/md5.
    This package is still not baked by openssl because upstream haven't implemented the boring bindings for it, as it is not FIPS approved nor generally recommended. Yet, we (Microsoft) need to support MD5 in case someone doesn't need FIPS and gets a policy exception.
    Only available if FIPS mode is not enabled.

sha.go Outdated Show resolved Hide resolved
sha.go Outdated Show resolved Hide resolved
sha.go Outdated Show resolved Hide resolved
sha.go Show resolved Hide resolved
@qmuntal
Copy link
Collaborator Author

qmuntal commented Aug 25, 2023

@ueno @derekparker can you take a look at this? Thanks!

@qmuntal
Copy link
Collaborator Author

qmuntal commented Aug 31, 2023

Friendly PTAL remained @derekparker @ueno

@qmuntal qmuntal merged commit 13f20f3 into v2 Aug 31, 2023
16 checks passed
@qmuntal qmuntal deleted the md4md5 branch August 31, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants