Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: type assertion panic in types2.(*Checker).instantiatedType (1.24rc1) #71250

Closed
prattmic opened this issue Jan 13, 2025 · 4 comments
Assignees
Labels
BugReport Issues describing a possible bug in the Go implementation. compiler/runtime Issues related to the Go compiler and/or runtime. compiler/telemetry-wins NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone

Comments

@prattmic
Copy link
Member

prattmic commented Jan 13, 2025

#!stacks
"cmd/compile/internal/types2.(*Checker).instantiatedType:+38"

Issue created by stacks.

This stack SiR3fA was reported by telemetry:

cmd/[email protected] go1.24rc1 darwin/arm64 (12)

This crash is a type assertion failure at https://cs.opensource.google/go/go/+/refs/tags/go1.24rc1:src/cmd/compile/internal/types2/typexpr.go;l=480;drc=b631b8e674195f6cdeca363ccb01279f14b10f13

inst := check.instance(x.Pos(), gtyp, targs, nil, check.context()).(genericType)

This type assertion is new in 1.24 (https://go.dev/cl/615275), so I am tentatively marking this a release blocker.

cc @griesemer @golang/compiler
Dups: 5UTERQ DeGb4g 9o-X9Q LUaCHQ 3uw3Qw NKGM6Q

@prattmic prattmic added compiler/runtime Issues related to the Go compiler and/or runtime. compiler/telemetry-wins NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Jan 13, 2025
@prattmic prattmic added this to the Go1.24 milestone Jan 13, 2025
@griesemer griesemer self-assigned this Jan 13, 2025
@prattmic
Copy link
Member Author

This stack 5UTERQ was reported by telemetry:

cmd/[email protected] go1.24rc1 linux/amd64 (10)

This stack DeGb4g was reported by telemetry:

cmd/[email protected] go1.24rc1 linux/amd64 (1)

This stack 9o-X9Q was reported by telemetry:

cmd/[email protected] go1.24rc1 darwin/arm64 (9)

This stack LUaCHQ was reported by telemetry:

cmd/[email protected] go1.24rc1 darwin/arm64 (5)

This stack 3uw3Qw was reported by telemetry:

cmd/[email protected] go1.24rc1 linux/amd64 (6)

This stack NKGM6Q was reported by telemetry:

cmd/[email protected] go1.24rc1 linux/amd64 (2)

@griesemer
Copy link
Contributor

griesemer commented Jan 13, 2025

I believe this is a dup of #71198 for which the fix will be submitted shortly: CL 641857.

@gabyhelp gabyhelp added the BugReport Issues describing a possible bug in the Go implementation. label Jan 13, 2025
@prattmic
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BugReport Issues describing a possible bug in the Go implementation. compiler/runtime Issues related to the Go compiler and/or runtime. compiler/telemetry-wins NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
None yet
Development

No branches or pull requests

3 participants