Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily remove throughput benchmark #555

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Temporarily remove throughput benchmark #555

merged 1 commit into from
Jun 7, 2024

Conversation

afsalthaj
Copy link
Contributor

I have to remove this to see a complete workflow of benchmark

  • Throughput benchmark kept failing in my machine. Firstly we need to ensure its running as consistent as other benchmarks before having this as part of the CI workflow.
  • I am currently looking at this.
  • This PR is to unblock rest of the benchmark jobs
  • Also as I mentioned earlier, it was a good idea to keep the number of jobs minimal when we test a workflows, and that's why I didn't have all of these jobs and it wasn't accidental

@afsalthaj afsalthaj changed the title Temporarily remove throughput Temporarily remove throughput benchmark Jun 7, 2024
@afsalthaj
Copy link
Contributor Author

I am merging this as it is a straight forward change, not impacting any other part of the code.

@afsalthaj afsalthaj merged commit ba6265c into main Jun 7, 2024
13 checks passed
@afsalthaj afsalthaj deleted the throughput branch June 7, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant