Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve update request feedback and documentation #948

Open
vigoo opened this issue Sep 19, 2024 · 1 comment
Open

Improve update request feedback and documentation #948

vigoo opened this issue Sep 19, 2024 · 1 comment
Labels
cli documentation Improvements or additions to documentation worker-service

Comments

@vigoo
Copy link
Contributor

vigoo commented Sep 19, 2024

When a worker update is initiated through the CLI or the REST API, it is not happening immediately, just get enqueued.

This should be made more clear by:

  • mentioning this in the documentation (learn.golem.cloud)
  • changing the Updated response in CLI to something more descriptive (at least "Update request sent")
  • the REST API should response with 202 not 200
@vigoo vigoo added documentation Improvements or additions to documentation cli worker-service labels Sep 19, 2024
@justcoon
Copy link
Contributor

justcoon commented Sep 23, 2024 •
edited
Loading

in relation to cli, golem-cli worker get ... --format text
it look like that text output do not showing updates https://github.com/golemcloud/golem/blob/main/golem-cli/src/model/text.rs#L747-L784
it would be nice to see there at least last update, especially if it is error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cli documentation Improvements or additions to documentation worker-service
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vigoo @justcoon