Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand the comprehensive test to cover all scenarios #986

Closed
afsalthaj opened this issue Oct 2, 2024 · 1 comment · Fixed by #989
Closed

Expand the comprehensive test to cover all scenarios #986

afsalthaj opened this issue Oct 2, 2024 · 1 comment · Fixed by #989
Assignees
Labels
Milestone

Comments

@afsalthaj
Copy link
Contributor

afsalthaj commented Oct 2, 2024

It looks like with the new mock_data, mock_interpreter, data-types extensive function metadata and component metadata, its now easier to expand on test_interpreter_complex_rib which is a dedicated module to test a complex Rib.

While we have dedicated test for each functionality, its important to test how it behaves when chaining them altogether, such as taking the result of a function and construct a variant.

Currently it looks like only 70%, which is already significantly better than what existed during the initial stages of Rib.

@afsalthaj afsalthaj self-assigned this Oct 2, 2024
@afsalthaj afsalthaj added the rib label Oct 2, 2024
@afsalthaj afsalthaj added this to the Golem 1.1 milestone Oct 2, 2024
@afsalthaj
Copy link
Contributor Author

Estimate is 3 considering we may encounter bugs (even if the initial comprehensive tests worked as it is, with no bug fixes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant