Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type checker #998

Closed
wants to merge 6 commits into from
Closed

Type checker #998

wants to merge 6 commits into from

Conversation

afsalthaj
Copy link
Contributor

No description provided.

@afsalthaj
Copy link
Contributor Author

Lot more issues discovered. There was progressive unification of types in every scan. Ideally this should only be for optimisation of inference. Removing it shouldn't result in test failures, but it did. Investigating it

thread 'type_inference::type_inference_tests::pattern_match_tests::test_pattern_match_with_record_with_select_index' panicked at golem-rib/src/type_inference/mod.rs:1379:62:
called `Result::unwrap()` on an `Err` value: ["Unknown", "Unable to resolve the type of pattern match expression match some(y) {  some(y) => y[0] } ", "Unknown", "Unable to resolve the type of index selection y[0]", "Unknown", "Unable to resolve the type of identifier y", "Unknown", "Unable to resolve the type of identifier y", "Unknown", "Unable to resolve the type of pattern match expression match some(x) {  some(x) => x.foo } ", "Unknown", "Unable to resolve the type of field selection x.foo", "Unknown", "Unable to resolve the type of identifier x", "Un-inferred type for field foo in record: Unknown", "Unable to resolve the type of identifier x", "Un-inferred type for field foo in record: Unknown"]


failures:
    interpreter::rib_interpreter::interpreter_tests::pattern_match_tests::test_interpreter_for_pattern_match_on_tuple_with_all_types
    interpreter::rib_interpreter::interpreter_tests::pattern_match_tests::test_interpreter_for_pattern_match_on_tuple_with_wild_pattern
    type_inference::type_inference_tests::pattern_match_tests::test_pattern_match_with_record
    type_inference::type_inference_tests::pattern_match_tests::test_pattern_match_with_record_with_select_field
    type_inference::type_inference_tests::pattern_match_tests::test_pattern_match_with_record_with_select_index
    type_inference::type_inference_tests::variable_conflict_tests::test_variable_conflict_case

@afsalthaj afsalthaj closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant