Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specifying subnet_tag does not override priority_head_subnet_tag #205

Open
shadeofblue opened this issue Mar 4, 2024 · 2 comments
Open
Assignees

Comments

@shadeofblue
Copy link
Contributor

shadeofblue commented Mar 4, 2024

The way I see it, when a user (Ray on Golem developer in this case) specifies any subnet_tag, it's pretty obvious that they want to run their ray requestor against a specific set of provider nodes and none other...

Therefore, intuition tells me that any nodes that are selected as ray instances for the user, should only come from that explicitly named subnet tag.

Actual result:
Despite some specific subnet tag being specified in the cluster definition file, ray-on-golem still uses ray-on-golem-heads to select nodes for the Ray's head node.

To achieve the expected result, one needs to provide both subnet_tag and priority_head_subnet_tag...

Expected result:
When a user specifies the subnet_tag in my cluster definition file, that selection should also override the priority_head_subnet_tag and all of users' nodes should be selected from the given network.

@mateuszsrebrny
Copy link
Contributor

I am not sure if I agree - this is not intended for external users, therefore I don't see it being a problem that devs need to add both properties.
Let's talk at some point :)

@mateuszsrebrny
Copy link
Contributor

@approxit says that the subnet override golem-cluster.override.5-subnet.yaml is having both - so this shouldn't be misleading.

Leaving as a backburner if someone ever wants to fix it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants