Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes #210

Merged
merged 18 commits into from
Mar 15, 2024
Merged

Minor fixes #210

merged 18 commits into from
Mar 15, 2024

Conversation

approxit
Copy link
Contributor

@approxit approxit commented Mar 12, 2024

What I've done:

Closes #209, #202

@approxit approxit changed the base branch from main to develop March 12, 2024 06:39
@approxit approxit force-pushed the approxit/minor-fixes branch from dda77a1 to d274f99 Compare March 14, 2024 15:16
@approxit approxit requested a review from lucekdudek March 14, 2024 15:38
Copy link
Contributor

@shadeofblue shadeofblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

stdout, stderr = await asyncio.wait_for(
process.communicate(),
timeout.total_seconds() if timeout else None,
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we stop the process or something like that?

@approxit approxit merged commit 6a7511c into develop Mar 15, 2024
2 checks passed
@approxit approxit deleted the approxit/minor-fixes branch March 15, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yagna payment status subprocess sometimes never ends
3 participants