Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We might not need ActorNursery._join_procs: trio.Event in the long run #301

Open
goodboy opened this issue Feb 12, 2022 · 0 comments
Open
Labels
cancellation SC teardown semantics and anti-zombie semantics question Further information is requested supervision

Comments

@goodboy
Copy link
Owner

goodboy commented Feb 12, 2022

Digging in deep with #165 I noticed the only reason we need this "nursery is now exited by parent* event was due to the .run_in_actor() style task-per-actor API we're debating dropping as in #290. Without this event, errors from remote actors are effectively raised right away since there is no collection of task per actor style teardown - this is the cause of a test suite massacre if I just remove it and run the CI 😂

If we were to remove this:

  • spawn tasks move on immediately to a soft_wai() which is just as fine a spot to block right?
  • is there any reason to ensure error checking from remote tasks is delayed until an ActorNursery.__aexit__()? No right, since all errors should be raised immediately (presuming no IPC msging failures) at a higher level then the process spawning/lifetime management?

More thinking to do on this fo sho 🏄🏼

@goodboy goodboy added cancellation SC teardown semantics and anti-zombie semantics question Further information is requested supervision labels Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cancellation SC teardown semantics and anti-zombie semantics question Further information is requested supervision
Projects
None yet
Development

No branches or pull requests

1 participant