RELATED: F1-645 FlexAI basic UI #5339
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andriichumak
requested review from
ivanmjartan
and removed request for
kandl
andriichumak
force-pushed
the
ach/flex-ai
branch
from
c38906e
to
d714573
Compare
andriichumak
commented
Sep 11, 2024
There was a problem hiding this comment.
It is curious that these 3 packages are added here only now. They are used in other sdk-ui-* packages, that's why I've chosen them..
|
Job gooddata-ui-sdk-unit-tests at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-unit-tests/21736/ finished with 'FAILURE' status. |
andriichumak
force-pushed
the
ach/flex-ai
branch
from
d714573
to
2d5d396
Compare
|
Job gooddata-ui-sdk-unit-tests at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-unit-tests/21738/ finished with 'FAILURE' status. |
added 2 commits
September 11, 2024 16:41
- React components prepared for design review JIRA: F1-645 risk: low
andriichumak
force-pushed
the
ach/flex-ai
branch
from
2d5d396
to
9b997cd
Compare
- Added dummy unit test, as I don't want to drop test infra, but have nothing to test yet jira: F1-645 risk: low
andriichumak
force-pushed
the
ach/flex-ai
branch
from
9b997cd
to
89bd759
Compare
|
Job gooddata-ui-sdk-unit-tests at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-unit-tests/21745/ finished with 'SUCCESS' status. |
|
Closing in favour of new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Please, don't forget to run
rush changefor the commits that introduce new features 🙏Refer to documentation to see how to run checks and tests in the pull request. This is the list of the most used commands: