Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why mediapipe v0.10.15 depends on numpy (<2) and v0.10.14 doesn't? #5612

Open
alanwilter opened this issue Sep 6, 2024 · 6 comments
Open
Assignees
Labels
dependencies Pull requests that update a dependency file platform:python MediaPipe Python issues stat:awaiting googler Waiting for Google Engineer's Response task::all All tasks of MediaPipe type:feature Enhancement in the New Functionality or Request for a New Solution

Comments

@alanwilter
Copy link

My code is working fine with MP v0.10.14 and numpy v2.0.2.
I can't update to numpy v2.1.1 yet because I use numba, whose v0.60.0, is not yet updated for latest numpy.

Anyway, when I was trying to update to latest MP, I got this warning.

Because mediapipe (0.10.15) depends on numpy (<2)

Was this pinning introduced on purpose to address some particular issue?

@alanwilter alanwilter added the type:others issues not falling in bug, perfromance, support, build and install or feature label Sep 6, 2024
@kuaashish kuaashish added type:support General questions task::all All tasks of MediaPipe platform:python MediaPipe Python issues and removed type:others issues not falling in bug, perfromance, support, build and install or feature labels Sep 6, 2024
@ayushgdev ayushgdev assigned ayushgdev and unassigned kuaashish Sep 16, 2024
@ayushgdev ayushgdev added the dependencies Pull requests that update a dependency file label Sep 16, 2024
@ayushgdev
Copy link
Collaborator

Hello @alanwilter
The Numpy version was downgraded to <2 in this commit. This was done for the stability of the package across all platform architectures.
With newer features coming to MediaPipe, we internally encountered issues packet propagation in MP graph with numpy 2.0.2 and hence downgrade was required.

@ayushgdev ayushgdev added the stat:awaiting response Waiting for user response label Sep 16, 2024
@alanwilter
Copy link
Author

Many thanks for that. Do you have an idea when numpy 2.1.x will be supported?

@google-ml-butler google-ml-butler bot removed the stat:awaiting response Waiting for user response label Sep 16, 2024
@ayushgdev
Copy link
Collaborator

@alanwilter This will depend on factors like the dependent packages used in MediaPipe(similar to numba package in your project), the stability(as we have already encountered), the performance and acceptable accuracy for each of the supported tasks.

Hence, we cannot comment on the timeline for the time being.

@ayushgdev ayushgdev added the stat:awaiting response Waiting for user response label Sep 17, 2024
Copy link

This issue has been marked stale because it has no recent activity since 7 days. It will be closed if no further activity occurs. Thank you.

@github-actions github-actions bot added the stale label Sep 25, 2024
@alanwilter
Copy link
Author

How can we prevent this ticket to be automatically closed by the the GitHub Bot?

@google-ml-butler google-ml-butler bot removed stale stat:awaiting response Waiting for user response labels Sep 25, 2024
@kuaashish
Copy link
Collaborator

Hi @alanwilter,

This can be marked as a feature request for supporting NumPy versions>2. We will share it with the team, and based on future demand and discussions, we may proceed with implementation if everything aligns on our end.

Thank you!!

@kuaashish kuaashish added type:feature Enhancement in the New Functionality or Request for a New Solution stat:awaiting googler Waiting for Google Engineer's Response and removed type:support General questions labels Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file platform:python MediaPipe Python issues stat:awaiting googler Waiting for Google Engineer's Response task::all All tasks of MediaPipe type:feature Enhancement in the New Functionality or Request for a New Solution
Projects
None yet
Development

No branches or pull requests

4 participants