From d04c13ced0c893258fde49e6eb99c81b4297a55a Mon Sep 17 00:00:00 2001 From: Marc Lanctot Date: Mon, 16 Dec 2024 16:38:43 +0000 Subject: [PATCH] Disable Go API until tests are fixed. PiperOrigin-RevId: 706721698 Change-Id: Ie91a052b06cf8fc20423be17dc905320847f555f --- open_spiel/CMakeLists.txt | 6 +++++- open_spiel/go/CMakeLists.txt | 19 ++++++++++++++----- 2 files changed, 19 insertions(+), 6 deletions(-) diff --git a/open_spiel/CMakeLists.txt b/open_spiel/CMakeLists.txt index 8f9b4743b3..8a3c08acbd 100644 --- a/open_spiel/CMakeLists.txt +++ b/open_spiel/CMakeLists.txt @@ -281,7 +281,11 @@ add_subdirectory (games) add_subdirectory (game_transforms) if (OPEN_SPIEL_BUILD_WITH_GO) - add_subdirectory(go) + message(WARNING + "GO API is disabled for now due to failing tests.\n" + "See https://github.com/google-deepmind/open_spiel/issues/1301." + ) + # add_subdirectory(go) endif() if (OPEN_SPIEL_BUILD_WITH_RUST) diff --git a/open_spiel/go/CMakeLists.txt b/open_spiel/go/CMakeLists.txt index 94d356ce49..95ad95e806 100644 --- a/open_spiel/go/CMakeLists.txt +++ b/open_spiel/go/CMakeLists.txt @@ -1,3 +1,11 @@ +# Note: GO API is disabled in ../CMakeLists.txt for now due to failing tests: +# # openspiel_test +# [openspiel_test] +# ./example_leduc_test.go:14:1: ExampleLeduc refers to unknown identifier: Leduc +# ./example_test.go:10:1: ExampleTicTacToe refers to unknown identifier: TicTacToe +# ./example_test.go:138:1: ExampleLoadParametrizedGame refers to unknown identifier: LoadParametrizedGame +# FAIL openspiel [build failed] + set(GO_BINDINGS ${GO_BINDINGS} go_open_spiel.cc go_open_spiel.h @@ -24,8 +32,9 @@ endforeach(go_api_file) execute_process(COMMAND go mod init openspiel WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}) -add_test(NAME gospiel_test COMMAND go test -v) -set_property(TEST gospiel_test - PROPERTY ENVIRONMENT - LD_LIBRARY_PATH=${CMAKE_CURRENT_BINARY_DIR}; - TEST_SRCDIR=${CMAKE_CURRENT_BINARY_DIR}) + +# add_test(NAME gospiel_test COMMAND go test -v) +# set_property(TEST gospiel_test +# PROPERTY ENVIRONMENT +# LD_LIBRARY_PATH=${CMAKE_CURRENT_BINARY_DIR}; +# TEST_SRCDIR=${CMAKE_CURRENT_BINARY_DIR})