AFL maybe_linking regression
#110
Comments
|
Some build systems seem to require to have afl-llvm-rt also when compiling, in fact they were failing with the old afl. Agree that -E is a special case, problably as you said the best option is to distinguish compilation and just preprocessing |
Yes, this is difficult to get right for AFL in the first place, because it requires the same logic as the sanitizer runtime linking logic and that one is complex enough. However, |
In 3ef34c1 the
maybe_linkinglogic was removed, which will break any build system that invokes the compiler with-Efor preprocessing only. We need to add the logic back at least for-E.However, I am also concerned about the removal of the
-sharedcase, which I added long ago to afl-clang-fast because it failed with mozilla-central otherwise. If multiple definitions of the runtime are linked into a single binary, the linker will deduplicate these in most cases (I wouldn't rely on this either, but I believe most modern linkers can deal with this). However, if you add the runtime to a shared library and a binary and then load the shared library into the binary, you will end up with two runtimes. This can potentially break stuff (we fixed this with sanitizers before, where it caused major problems).I will try to come up with a PR later that adds the
-Elogic and maybe the-sharedlogic as well.Cc @andreafioraldi
The text was updated successfully, but these errors were encountered: