Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip wheels metadata should indicate that they are built for x86-64 #71

Open
joker-eph opened this issue Aug 6, 2023 · 4 comments
Open

Comments

@joker-eph
Copy link

Right now the wheels are published as array_record-0.4.0-py310-none-any.whl ; which gets them installed on linux arm64 even though they provide x86 binaries.

@nouiz
Copy link

nouiz commented Sep 26, 2023

@cantonios any update on this?

@cantonios
Copy link
Contributor

Pinging @Marvin182

@nouiz
Copy link

nouiz commented Oct 5, 2023

#79 Fix new wheel creation.
This come from JAX setup.py files.

Doing a new release of array_record would be a partial fix, as the latest will be fixed.
But any idea how to a full fix?
Could we do a new release soon after the merge to prevent many users complaints?

@nouiz
Copy link

nouiz commented Nov 3, 2023

The release was done.
We need to bump the requirement on packges that depend on array_record to not have it install the older packages. But now we can prevent it. Look at tensorflow/datasets#5109 for an example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants