Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document all unsafe and fix pinning booboos #833

Closed
adetaylor opened this issue Feb 24, 2022 · 2 comments · Fixed by #855
Closed

Document all unsafe and fix pinning booboos #833

adetaylor opened this issue Feb 24, 2022 · 2 comments · Fixed by #855
Labels
bug Something isn't working release-blocker

Comments

@adetaylor
Copy link
Collaborator

There are some instances of unsafe which do not have adequate documentation about why they're safe.
@adetaylor adetaylor mentioned this issue Feb 28, 2022
Merged
@adetaylor
Copy link
Collaborator Author

I raised this issue because I was a bit suspicious of some of my pinning choices, and indeed, I made a booboo. Marking this as a release blocker bug to fix it.

@adetaylor adetaylor added bug Something isn't working release-blocker labels Feb 28, 2022
@adetaylor adetaylor changed the title Document all unsafe Document all unsafe and fix pinning booboos Feb 28, 2022
adetaylor added a commit that referenced this issue Mar 1, 2022
@adetaylor
Fix moved-in-memory problem.
dade678 
Partially fixes #833.
@adetaylor adetaylor mentioned this issue Mar 1, 2022
Merged
@adetaylor
Copy link
Collaborator Author

A specific problem with my pinning logic was reported here: #766 (comment)
#855 fixes this, but #856 says the fix is ugly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working release-blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix pin prob google/autocxx
1 participant
@adetaylor