Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Internationalization #117

Open
inetbiz opened this issue Nov 13, 2021 · 2 comments
Open

Feature: Internationalization #117

inetbiz opened this issue Nov 13, 2021 · 2 comments

Comments

@inetbiz
Copy link

inetbiz commented Nov 13, 2021

https://github.com/google/eleventy-high-performance-blog/blob/main/_includes/layouts/base.njk#L2

<html lang="en"
    domain="{{ metadata.domain }}"
    {% if googleanalytics %}
    ga-id="{{ googleanalytics }}"
    {% endif %}
  >

Move lang= to site.json to define the language type. en-US as an example instead of just en.
@cramforce
Copy link
Collaborator

This makes some sense. TBH site.json helps very little. That just changes where the value is edited which might still be better, but for true i18n you'd want to do this on a per-page basis.

@inetbiz
Copy link
Author

inetbiz commented Nov 13, 2021

OK so define var In the base template? ok!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cramforce @inetbiz