From 9ba0ea780536c07568b13db68fb3e6e731e0f146 Mon Sep 17 00:00:00 2001 From: Jacob Su Date: Sun, 24 Sep 2023 23:00:45 +0800 Subject: [PATCH] fix test_gltfio failed UT. --- libs/gltfio/test/gltfio_test.cpp | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/libs/gltfio/test/gltfio_test.cpp b/libs/gltfio/test/gltfio_test.cpp index 5f6fd2d3c0d..e678c62688d 100644 --- a/libs/gltfio/test/gltfio_test.cpp +++ b/libs/gltfio/test/gltfio_test.cpp @@ -160,6 +160,21 @@ TEST_F(glTFIOTest, AnimatedMorphCubeMaterials) { EXPECT_EQ(name, "Material"); } +// A macro to help with mat comparisons within a range. +#define EXPECT_MAT_NEAR(MAT1, MAT2, eps) \ +do { \ + const decltype(MAT1) v1 = MAT1; \ + const decltype(MAT2) v2 = MAT2; \ + EXPECT_EQ(v1.NUM_ROWS, v2.NUM_ROWS); \ + EXPECT_EQ(v1.NUM_COLS, v2.NUM_COLS); \ + for (int i = 0; i < v1.NUM_ROWS; ++i) { \ + for (int j = 0; j < v1.NUM_COLS; ++j) \ + EXPECT_NEAR(v1[i][j], v2[i][j], eps) << \ + "v[" << i << "][" << j << "]"; \ + } \ +} while(0) + + TEST_F(glTFIOTest, AnimatedMorphCubeTransforms) { FilamentAsset const& morphCubeAsset = *mData[ANIMATED_MORPH_CUBE_GLB]->getAsset(); auto const& transformManager = mEngine->getTransformManager(); @@ -177,8 +192,10 @@ TEST_F(glTFIOTest, AnimatedMorphCubeTransforms) { auto const result = inverse(transform) * expectedTransform; + float const value_eps = float(0.00001) * std::numeric_limits::epsilon(); + // We expect the result to be identity - EXPECT_EQ(result, math::mat4f{}); + EXPECT_MAT_NEAR(result, math::mat4f{}, value_eps); } TEST_F(glTFIOTest, AnimatedMorphCubeRenderables) {