-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(v2): vendor go/pkgsite/source package for remote URL discovery #95
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's put this in internal/third_party - we don't want to take on responsibility of maintain this package for others.
5c0f5db
to
cb9e7d8
Compare
Hi @wlynch, I updated the PR to
Note that, I did these in clear and separate commits, each commit does just one thing. |
28e7fde
to
6c1b158
Compare
Updated to target master branch in root folder. |
Part of #73
I've already verified this module works perfectly for our usecases in following up PRs.
I asked whether pkgsite can move the internal package out, but I got reply that we need to vendor it, golang/go#40477 (comment).