Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing staticcheck linter issues #7

Open
sluongng opened this issue Jul 9, 2021 · 1 comment
Open

Fixing staticcheck linter issues #7

sluongng opened this issue Jul 9, 2021 · 1 comment

Comments

@sluongng
Copy link
Contributor

sluongng commented Jul 9, 2021

Expected Behavior

Current code should pass staticcheck linting

Actual Behavior

git_protocol_v2_handler.go:133:55: should use time.Since instead of time.Now().Sub (S1012)
managed_repository.go:118:41: should use time.Since instead of time.Now().Sub (S1012)
reporting.go:96:40: should use time.Since instead of time.Now().Sub (S1012)
reporting.go:148:9: infinite recursive call (SA5007)

Steps to Reproduce the Problem

  1. Run staticcheck

Specifications

  • Version:
  • Platform:
@sluongng
Copy link
Contributor Author

sluongng commented Jul 9, 2021

I have a branch for fixing this https://github.com/sluongng/goblet/tree/sluongngoc/fix-staticcheck

Will submit a PR soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sluongng