Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seeking workaround for git url #158

Open
hagevvashi opened this issue Mar 9, 2021 · 0 comments
Open

Seeking workaround for git url #158

hagevvashi opened this issue Mar 9, 2021 · 0 comments

Comments

@hagevvashi
Copy link

hagevvashi commented Mar 9, 2021

I have a problem about PackageNotFoundError.

If using github url for package.json (e.g. dependencies: { "package-a": "git+ssh://[email protected]/...." }), above error occurs after execute jsgl --local ..

The reason is package-json does not support git url and the issue is here.

As described above, I understand the unnecessity of fetching package from git url (because the aim of js-green-licenses is also for the open source library's license).

However, for some reasons (e.g. there are no private registries in the organization), it is not possible to remove those git url packages.

So I have 3 proposals.

  1. remove package directed to git url before iterating
  2. if package is allow-listed and is directed to git url, do not fetch from npm registry
  3. using git-package-json

At last I have a question.

Do you think which workaround is the best?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants