Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KSP2] "PSI has changed since creation" in SymbolProcessor::finish #2113

Open
kuanyingchou opened this issue Sep 20, 2024 · 0 comments
Open

Comments

@kuanyingchou
Copy link
Collaborator

kuanyingchou commented Sep 20, 2024

I saw this in XProcessing's XTypeTest.wildcardWithMissingType and this could be more of a feature request.

In XProcessing we run a pseudo last run when SymbolProcessor::finish is called here and may still try to access types and annotations in finish. But we're hitting PSI has changed since creation. Could it be that things are cleaned up here?

If it is since there're no new files generated and the caches are still valid is it possible to delay the clean up in the last round so that we won't hit this error in onError or finish? For example, if there're two rounds, instead of:

round 1
clean up
round 2 (final round)
clean up
onError or finish

we do:

round 1
clean up
round 2 (final round)
onError or finish
clean up

This one looks similar to #1854.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant