Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to decode downloaded font + OTS parsing error (Windows 7 x64, Chrome 109) #1798

Open
777-0-777 opened this issue Sep 28, 2024 · 26 comments

Comments

@777-0-777
Copy link

Windows 7 x64, Chrome 109

Icons show raw texts!

Failed to decode downloaded font: https://fonts.gstatic.com/s/googlematerialicons/v142/Gw6kwdfw6UnXLJCcmafZyFRXb3BL9rvi0QZG3Q.woff2

OTS parsing error: Unable to instantiate font face from font data.

2
3
4
1

@777-0-777
Copy link
Author

The problem appeared approximately one week ago.

Please fix it.

@777-0-777
Copy link
Author

777-0-777 commented Oct 2, 2024

Such a problem has arisen before:

#1220

@777-0-777
Copy link
Author

@garretrieger Can you fix this?

@simone-desantis
Copy link

It's worth mentioning that this issue seems not be there when using the latest build of win7

@simone-desantis
Copy link

Also: It is introduced in v142 , v141 works fine.

@garretrieger
Copy link
Member

I'm not able to get this to reproduce locally for me, do you see the issue on this test page?

https://codepen.io/garretrieger/full/xxvRgOJ

Also what version of windows 7 are you on?

@simone-desantis
Copy link

I am reproducing it in one of the earliest win7 builds: 7600
Here you see a temporary workaround demo: https://github.com/simone-desantis/chrome-font-replacer
Here is your rendering:
Image

@garretrieger
Copy link
Member

Thanks, since this is only failing on specific versions of windows 7 this seems like it's very likely the same issue as #1220. I'll check the font binaries between v141 and v142 and see if I can spot any changes in ordering of coverage data that would trigger the bug in #1220.

@777-0-777
Copy link
Author

777-0-777 commented Oct 12, 2024

I'm not able to get this to reproduce locally for me, do you see the issue on this test page?

https://codepen.io/garretrieger/full/xxvRgOJ

Also what version of windows 7 are you on?

@garretrieger

Image
Windows 7 Professional Build 7601 Service Pack 1

Image

@OrionisQul
Copy link

OrionisQul commented Oct 13, 2024 via email

@777-0-777
Copy link
Author

777-0-777 commented Oct 23, 2024

@garretrieger

Is there any news?

@garretrieger
Copy link
Member

Can you try this new test page and let me know which of the samples fails to load? https://garretrieger.github.io/font-debugging/index.html

@simone-desantis
Copy link

simone-desantis commented Oct 25, 2024

Home and logout base 142:
Image

@garretrieger
Copy link
Member

Thanks, this is very helpful! I've updated that page with some additional tests would you be able to check again?

@simone-desantis
Copy link

Absolutely:
Image

@garretrieger
Copy link
Member

Alright, I've narrowed down the problem to likely being in the CFF table encoding. I've got a temporary fix that I've deployed to our test API and if that looks like it works we can get the fix out for the prod font early next week.

Could you check this test page which includes the updated font from the test api?

https://codepen.io/garretrieger/full/JjgMXza

If the fix worked, then v143 should load without errors.

@tomasdev
Copy link
Collaborator

tomasdev commented Oct 26, 2024

Home and logout base 142:

[offtopic]

@simone-desantis If you don't mind me asking... why are you on Windows 7 to which Microsoft stopped sending security updates in 2020?

@simone-desantis
Copy link

@garretrieger issue fixed
Here the result:
Image

@simone-desantis
Copy link

@tomasdev I am not :) I crossed this problem and helped to debug.
It's strongly discouraged to use such setup.
I am mentioning this as disclaimer in the temporary workaround I made available here:
https://github.com/simone-desantis/chrome-google-font-replacer?tab=readme-ov-file#disclaimer-1

@777-0-777
Copy link
Author

777-0-777 commented Oct 27, 2024

Image
Image
Image
Windows 7 Professional Build 7601 Service Pack 1

@garretrieger
Copy link
Member

Ok great looks like the fix works. We'll get the process started of rolling this out to prod. Should land in production in a couple of days.

@garretrieger
Copy link
Member

The fixed version is now on prod. You may need to clear your browser cache to get it.

@simone-desantis
Copy link

I confirm that the v143 is correctly renderd. Just FYI i.e. calendar still hasn't rolled out the v143. Is this in the hands of the google workspace team?

@garretrieger
Copy link
Member

I'll check in on that and see if I can get it updated.

@garretrieger
Copy link
Member

The fix should be out now for calendar.

@simone-desantis
Copy link

Yes it is, I guess that then this is done 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants