Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft's Windows 11 reports that Google's material-design-icons-4.0.0.zip is invalid #1829

Open
Gitoffthelawn opened this issue Nov 3, 2024 · 3 comments

Comments

@Gitoffthelawn
Copy link

Microsoft's Windows 11 Professional (v10.0.22631) reports that material-design-icons-4.0.0.zip is invalid.

STR:

  1. Download material-design-icons-4.0.0.zip from this GitHub repo.
  2. In Microsoft's File Explorer, double-click the file to open it (or right-click it and select Open, or for keyboard warriors, simply select the file and press Enter).
  3. The following error will display:
Compressed (zipped) Folders Error

Windows cannot open the folder.

The Compressed (zipped) Folder '..\material-design-icons-4.0.0.zip' is invalid.

There's either a problem with Google's zip file or Microsoft's software.

FWIW, I tested the zip file with 7-Zip v24.08, and it did not report any errors.

@tphinney
Copy link
Collaborator

tphinney commented Nov 7, 2024

Do you have a URL for the file?

I will note that those are the old icons that have not been updated in about four years, and it works fine with 7-zip, so it is unlikely that there is anything wrong with the zip file other than being really darn big and having a LOT of folders or files all at one level.

@Gitoffthelawn
Copy link
Author

Gitoffthelawn commented Nov 8, 2024

Do you have a URL for the file?

It's the first file available in the Releases section of this repo. To access the Releases section of this repo, click this link. Then under "Assets", you'll see "Source code (zip)". Click on that link, and you'll get the file.

This direct link may work too (it works for me), but it relies on GitHub redirecting properly, which I can't guarantee:
https://github.com/google/material-design-icons/archive/refs/tags/4.0.0.zip

@tphinney
Copy link
Collaborator

tphinney commented Nov 8, 2024

I was able to unzip just fine on my end. Not sure if that was the default Mac un-archiver or some other utility I have installed.

Looking at the structure, it does use category folders, so it does not have a completely absurd number of files or folders at any one level. However, it also has EVERY flavor of derivative file all in the one archive! So... the total count is truly massive: 549,328 items (files and folders both, one assumes).

The file is 157 MB, but it consumes nearly 10x as much space on my disk because of the huge number of very small files (each one a fraction of the minimum block size).

I am not immediately convinced there is anything actually “wrong” with the archive. But also:

  • you found a pretty easy workaround
  • this old release is now deprecated (actually, the whole “material icons” series, not just this version of it)
  • nobody else has reported this issue in the 4+ years since that release, from my search of the repo issues
  • I have no idea what one would do to “fix” the problem, aside from trying segmenting it into smaller archives, each for a different format of the output set such as iOS icons, SVG icons, etc. (Might work, might not. I have no confidence in it, just the first thing that comes to mind.)

So, not meaning to be arbitrarily dismissive of the problem (and taking the time to report things is good!), yet... I am inclined to punt on the issue and ignore it as not worth pursuing. If there are factors I don’t seem to be considering, that you think make it worth spending time on, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants