Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Net names + airwires #11

Open
amstan opened this issue Apr 13, 2019 · 4 comments
Open

Net names + airwires #11

amstan opened this issue Apr 13, 2019 · 4 comments
Labels
feature request New feature, request or enhancement jim Stuff that we need working for Jim svg Stuff related to the svg output

Comments

@amstan
Copy link
Contributor

amstan commented Apr 13, 2019

Nets should be able to get labeled with the net name.

If a net doesn't go anywhere but one pin, it should make a little stub, long enough to fit its name.

Duplicate of nturley/netlistsvg#36

Right now we can simulate this by uncommenting

pcbdl/pcbdl/netlistsvg.py

Lines 203 to 204 in 0c02c3d

##if len(pin_net_helper.grouped_connections) > 1:
#self.attach_net_name_port(pin.net, net_node_number, port_directions[name])

@amstan amstan added duplicate This issue or pull request already exists feature request New feature, request or enhancement svg Stuff related to the svg output labels Apr 13, 2019
@amstan
Copy link
Contributor Author

amstan commented Mar 25, 2020

Done some work on this in my netlistsvg fork. It's essentially almost done.

  • Chips have pin names inside them (unrelated to this bug)
  • netnames passed to json
  • netnames show on random lines if they're named and not power
  • netnames show even when there's no net there (an airwire gets generated)

Screenshot_20200311_193001

@amstan amstan added jim Stuff that we need working for Jim and removed duplicate This issue or pull request already exists labels Mar 25, 2020
amstan added a commit that referenced this issue Apr 12, 2020
* add netname information in json to be given to netlistsvg
* reorganize the classes in netlistsvg.py a little bit

BUG=Issue #11
TEST=Together with https://github.com/amstan/netlistsvg/tree/for-pcbdl, see new netnames all over the place
@amstan
Copy link
Contributor Author

amstan commented Apr 12, 2020

3 more problems left:

@amstan
Copy link
Contributor Author

amstan commented Apr 13, 2020

Let's call this working enough for Jim.

@amstan amstan removed the jim Stuff that we need working for Jim label Apr 13, 2020
@amstan amstan added the jim Stuff that we need working for Jim label Jun 26, 2020
@amstan
Copy link
Contributor Author

amstan commented Jun 26, 2020

Jim noticed no airwires on resistors and thin chips already.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature request New feature, request or enhancement jim Stuff that we need working for Jim svg Stuff related to the svg output
Projects
None yet
Development

No branches or pull requests

1 participant