As a second admin, banners still show even after disabling the feature

[wpdarren]

Bug Description

Created from bug bash. Asana ticket can be found here.

As a second admin, banners still show even after disabling the feature.

Steps to reproduce

1. Setup AS as an admin
2. Switch to a secondary admin account, got to the settings and disable the feature
3. When you go back to the dashboard you still see the setup banner and subtle success notification even though the widget area is now hidden.

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• Given that the Intro Popup/Banner has not been dismissed for a secondary user:
  • If the user toggles the "Display visitor groups in the dashboard" setting off, the popup/banner should no longer show up on the dashboard.
  • Toggling the setting on again should restore the popup/banner.
• The Setup Success Banner should not appear at all for a secondary user, however this will be addressed via As a second admin, the setup subtle notification is displayed #9482.

Implementation Brief

• In the AudienceSegmentationIntroductoryOverlayNotification component, retrieve the isAudienceSegmentationWidgetHidden value. Add a check for isAudienceSegmentationWidgetHidden === false to the condition that determines if the notification should be displayed:

site-kit-wp/assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceSegmentationIntroductoryOverlayNotification.js

Lines 110 to 113 in dfcc37f

	const shouldShowNotification =
	isDismissed === false &&
	shouldShowAudienceSegmentationIntroductoryOverlay &&
	DASHBOARD_TYPE_MAIN === dashboardType;

Test Coverage

• Add a test case to the JS tests for the component, and fix its story/VRT.

QA Brief

• Follow the steps to reproduce, and confirm the Intro Popup/Banner does not appear.
• Toggle the feature back on, and return to the dashboard. The Intro Popup/Banner should reappear.

Note that, as per the AC, the Setup Success Banner will be addressed separately via #9482.

Changelog entry

• Fix an issue that caused the visitor groups overlay notification to appear unexpectedly.

[nfmohit]

IB ✅

[mohitwp]

QA Update ⚠

• Tested on dev environment.
• Tested on both secondary admin dashboard and view only dashboard.
• Verified that issue is resolve now for secondary admin.
• Verified that when secondary admin disable the feature then widgets and banner do not appear on main dashboard.
• Note : I created separate ticket The AS widgets notification continue to appear under admin settings even after the feature has been disabled. #9541 for the notification showing under admin settings.

Question

@techanvil I've noticed that the banner and widgets still appear on the view-only dashboard, even after both the secondary and primary admins disable the feature. Is this expected behaviour? My understanding is that if the primary admin who shared the modules disables the feature, the banner should no longer appear on the view-only dashboard.

Here’s the sequence I observed:

1. The primary admin sets up and shares the Analytics module with the secondary admin and the view-only dashboard.
2. The secondary admin disables the feature under settings.
3. The banner stops appearing on the main dashboard for the secondary admin.
4. The primary admin also disables the feature under settings.
5. When logging in as a view-only user, the banner and widgets still show on the view-only dashboard.
6. Could you please share your thoughts on this?

Recording.1533.mp4

PASS CASE

Recording.1532.mp4

[techanvil]

Hi @mohitwp, thanks for checking in on this.

The "Display visitor groups in the dashboard" setting is per-user, not a global setting, so the behaviour you are seeing is as expected.

In fact, at the moment it's not possible for a view-only user to toggle the setting at all, as they don't have access to the Settings screen, this is a known shortcoming in the UX that we will address at some point but it's as expected for the time being.

[mohitwp]

QA Update ✅

• Tested on dev environment.
• Tested on both secondary admin dashboard and view only dashboard.
• Verified that issue is resolve now for secondary admin.
• Verified that when secondary admin disable the feature then widgets and banner do not appear on main dashboard.
• Note : I created separate ticket The AS widgets notification continue to appear under admin settings even after the feature has been disabled. #9541 for the notification showing under admin settings.

Recording.1532.mp4