Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpplint.py write error #751

Open
haobo724 opened this issue Jan 9, 2023 · 2 comments
Open

cpplint.py write error #751

haobo724 opened this issue Jan 9, 2023 · 2 comments
Labels

Comments

@haobo724
Copy link

haobo724 commented Jan 9, 2023

something wrong with function sys.stderr.write()
when I use cpplint.py from [email protected]:google/styleguide.git
the console always shows an Error msg:
TypeError('write() argument must be str, not bytes')
But if i use the cpplint.py from https://github.com/cpplint/cpplint everything goes well.

By comparison I found that it was a matter of how some of the error messages were called by function.
So I simply copied the file from https://github.com/cpplint/cpplint and rewrote the old one
I also creat a pull issue with title:
Error print from https://github.com/cpplint/cpplint fixed #750
#750

@Comiclyy
Copy link

Hello,
As google most likely has notified you when your pr failed due to unsigned CLA, please sign that as otherwise your pr will not be able to be merged. This issue most likely occurs because google has different internals than cpplint as you mentioned before. Also please refrain from opening an issue and a pr as it causes more problems for devs to go through.
Thanks.

@haobo724
Copy link
Author

Hello, As google most likely has notified you when your pr failed due to unsigned CLA, please sign that as otherwise your pr will not be able to be merged. This issue most likely occurs because google has different internals than cpplint as you mentioned before. Also please refrain from opening an issue and a pr as it causes more problems for devs to go through. Thanks.

thank you, now I have signed CLA

@vapier vapier added the cpplint label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants