Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/cover: simplify visual coverage comparison for two files #5381

Open
Tracked by #4911
tarasmadan opened this issue Oct 10, 2024 · 2 comments
Open
Tracked by #4911

pkg/cover: simplify visual coverage comparison for two files #5381

tarasmadan opened this issue Oct 10, 2024 · 2 comments
Assignees

Comments

@tarasmadan
Copy link
Collaborator

No description provided.

@dvyukov dvyukov changed the title simplify visual coverage comparison for two files pkg/cover: simplify visual coverage comparison for two files Oct 10, 2024
@tarasmadan
Copy link
Collaborator Author

tarasmadan commented Oct 10, 2024

@dvyukov the steps I'm thinking about are:

  1. Detect functions scope and for the equal functions remove the matching coverage markers.
  2. onclick(fold functions). It'll fold the functions in both views.
  3. Autofold functions if the coverage looks equal.
  4. Parallel scrolling.
  5. "Next diff" button.
  6. Highlight the file diff.

@tarasmadan tarasmadan self-assigned this Oct 10, 2024
@dvyukov
Copy link
Collaborator

dvyukov commented Oct 10, 2024

Hard to comment, only dogfooding it for lots of cases can lead to an option that's not painful to use.
I am also thinking about higher-level story. Nobody will access all changes in these reports visually each week by clicking on all files. Other related functionalities: summary of changes, automated large change detection. These shouldn't be based on UI and lots of clicking. Solving these may also solve the problem for a single file (e.g. if summary points to functions with largest changes, it will be possible to search for the function name on the current view).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants