Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New operator: z-score normalization #343

Open
ianspektor opened this issue Jan 17, 2024 · 3 comments
Open

New operator: z-score normalization #343

ianspektor opened this issue Jan 17, 2024 · 3 comments
Labels
good first issue Good for newcomers new operator Development of a new operator.

Comments

@ianspektor
Copy link
Collaborator

ianspektor commented Jan 17, 2024

New EventSet.z_score_normalize() (name TBD) operator.

See here for how to compute it.

See https://github.com/google/temporian/blob/main/CONTRIBUTING.md#developing-a-new-operator for guidance.

Questions or requests for additional guidance from possible contributors more than welcome!

@ianspektor ianspektor added good first issue Good for newcomers new operator Development of a new operator. labels Jan 17, 2024
@akshatvishu
Copy link
Contributor

akshatvishu commented Apr 2, 2024

Hey @ianspektor, I have a few questions about putting this into action:

Q1) Will this be a python-only operator or a c++ one?

Q2) As far as I understand, we can't use scipy. So, we can't call scipy.stats.zscore directly thus, I was wondering, do we keep the arguments same as scipy.stats.zscore ? Also, I'm interested in how we deal with NaNs .

Q3) What data types will this operator support? All numeric?

@ianspektor
Copy link
Collaborator Author

Tagging @javiber, he's the go-to person from now on for all things contributing :)

@javiber
Copy link
Collaborator

javiber commented Apr 10, 2024

Hi @akshatvishu I think that we can implement this one using numpy's mean and std whiteout going down to c++.

Scipy's implementation for future reference: https://github.com/scipy/scipy/blob/v1.13.0/scipy/stats/_stats_py.py#L3021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers new operator Development of a new operator.
Projects
None yet
Development

No branches or pull requests

3 participants