Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New operator: cumprod #350

Open
ianspektor opened this issue Jan 17, 2024 · 3 comments
Open

New operator: cumprod #350

ianspektor opened this issue Jan 17, 2024 · 3 comments
Assignees
Labels
good first issue Good for newcomers new operator Development of a new operator.

Comments

@ianspektor
Copy link
Collaborator

ianspektor commented Jan 17, 2024

New EventSet.cumprod() operator.

Depends on #380.

See EventSet.cumsum() for reference.

See https://github.com/google/temporian/blob/main/CONTRIBUTING.md#developing-a-new-operator for guidance.

Questions or requests for additional guidance from possible contributors more than welcome!

@ianspektor ianspektor added good first issue Good for newcomers new operator Development of a new operator. labels Jan 17, 2024
@akshatvishu
Copy link
Contributor

Hi @ianspektor! I'm happy to contribute to this issue.

@ianspektor
Copy link
Collaborator Author

Hey @akshatvishu!

When creating this issue I thought moving_product already existed, which isn't the case, which is why in the description I specified it should be implemented like cumsum is, which uses moving_sum.

Creating new ticket for that first operator, that this one depends on: #380

@akshatvishu
Copy link
Contributor

Hey @akshatvishu!

When creating this issue I thought moving_product already existed, which isn't the case, which is why in the description I specified it should be implemented like cumsum is, which uses moving_sum.

Creating new ticket for that first operator, that this one depends on: #380

I think I should do both of them together!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers new operator Development of a new operator.
Projects
None yet
Development

No branches or pull requests

2 participants