Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: add sample #101

Open
AndroidDeveloperLB opened this issue Sep 27, 2017 · 7 comments
Open

Request: add sample #101

AndroidDeveloperLB opened this issue Sep 27, 2017 · 7 comments

Comments

@AndroidDeveloperLB
Copy link

As the title says...

@jpd236
Copy link
Collaborator

jpd236 commented Sep 27, 2017

https://developer.android.com/training/volley/index.html has a decent chunk of sample code but I suppose it would be reasonable to package this up into full, working examples.

@jpd236 jpd236 added this to the 1.2.0 milestone May 3, 2018
@jamesdube
Copy link

I would be interested in helping with that

@AndroidDeveloperLB
Copy link
Author

@jpd236 I meant a working sample, as part of the repository.

@jamesdube
Copy link

@jpd236 I would like to work on the example(s) if that's okay?

@AndroidDeveloperLB
Copy link
Author

Please do. Could be nice.

@jpd236
Copy link
Collaborator

jpd236 commented Oct 16, 2019

Thanks for checking in first! I'd welcome some help here, but would be a bit worried that this could get kind of complicated and I'm not 100% sure how easy it would be to get to something I'd be comfortable merging in.

Samples can get fairly large depending on what they're showing, and I'm not 100% clear on how they'd fit into the existing repository (as a samples subdirectory? How/when would they get built/tested? Would people prefer standalone repositories that they could check out as fully-functional sample applications?). If you're interested in working on this, what I'd suggest is to first propose a high-level structure for how you'd plan to put together the samples and make sure we're in agreement there, and then start with something small and simple before moving onto any other complex sample code.

Another option you might consider is to start a standalone sample repository that you could iterate on a bit, and that perhaps once it is proven out as useful and complete, we could consider merging it here.

Let me know what you think - thanks again.

@jamesdube
Copy link

Thank you for your response, I agree with your proposal, probably I'll do a standalone repository and work from there, as for a high level overview let me work on that and get back to you quickly.

I do love Volley and would want to contribute as much as I can so If there are other areas as well that I could pitch in I would gladly love to do so.

@jpd236 jpd236 removed this from the 1.2.0 milestone Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants