RequestQueue.cancelAll doesn't use Object.equals

[CapnSpellcheck]

public boolean apply(Request<?> request) {
                return request.getTag() == tag;
            }

Why shouldn't it use Object.equals?

[jpd236]

That's a very good question. Unfortunately it appears to have always been this way, and is even documented as such in the cancelAll() Javadoc, which means it's not something we can change without breaking the API contract.

The original change adding this was at https://android.googlesource.com/platform/frameworks/support/+/19a56e8495477bfd89e4c4913860fdbcb7beb504, and even internally I don't see any explanation as to why it was done this way.

We can look at adding a new API and deprecating the old one in 1.2.0. In the mean time, it's possibly to specify your own RequestFilter as follows:

cancelAll(new RequestFilter() {
    @Override
    public boolean apply(Request<?> request) {
        return Objects.equals(tag, request.getTag());
    }
});

[CapnSpellcheck]

Of course. I just wanted to point this out :)

[runforprogram]

I think it is a intentional designed, RequestManager.cancelAll is a danger method which will to cause all of requests which tag equaled be canceled. use == can be minimize side effect.think this situation has two place request a same url and use a object like a url String
,want cancel A request but not B, use == will minimal probability cause B canceled than use
Objects.equals(tag, request.getTag())

[joimxjtuse]

i agree with @runforprogram, compare '==' with String.equals(), just for efficiency.

[joebowbeer]

In Request, the tag is defined as an opaque token.

A unit test for this functionality:

RequestQueueTest.java#L52