From 72961d5a8909d460f7e245fb232258dabb0632a5 Mon Sep 17 00:00:00 2001 From: Alex Light Date: Fri, 3 May 2024 13:07:16 -0700 Subject: [PATCH] Standardize cc_xls_ir_jit_wrapper class_names We would silently transform these into camel-case anyway. Make the class-name be camel case so we can stop doing this behavior and just take the class-name unchanged. This does not affect the generated code in any way. PiperOrigin-RevId: 630475745 --- third_party/xls_berkeley_softfloat/BUILD | 2 +- third_party/xls_go_math/BUILD | 8 ++++---- xls/build_rules/tests/BUILD | 2 +- xls/dslx/stdlib/BUILD | 18 +++++++++--------- xls/examples/BUILD | 2 +- xls/examples/apfloat_add_parallel/BUILD | 2 +- xls/examples/crc32/BUILD | 2 +- xls/examples/jpeg/BUILD | 2 +- 8 files changed, 19 insertions(+), 19 deletions(-) diff --git a/third_party/xls_berkeley_softfloat/BUILD b/third_party/xls_berkeley_softfloat/BUILD index 186163383b..53ea7fefea 100644 --- a/third_party/xls_berkeley_softfloat/BUILD +++ b/third_party/xls_berkeley_softfloat/BUILD @@ -49,7 +49,7 @@ cc_xls_ir_jit_wrapper( name = "fpdiv_2x32_jit_wrapper", src = ":fpdiv_2x32.opt.ir", jit_wrapper_args = { - "class_name": "fpdiv_2x32", + "class_name": "Fpdiv2x32", "namespace": "xls::fp", }, ) diff --git a/third_party/xls_go_math/BUILD b/third_party/xls_go_math/BUILD index 983fede446..49fb215f19 100644 --- a/third_party/xls_go_math/BUILD +++ b/third_party/xls_go_math/BUILD @@ -63,7 +63,7 @@ cc_xls_ir_jit_wrapper( name = "fpexp_32_jit_wrapper", src = ":fpexp_32.opt.ir", jit_wrapper_args = { - "class_name": "fpexp_32", + "class_name": "Fpexp32", "namespace": "xls::fp", }, ) @@ -135,7 +135,7 @@ cc_xls_ir_jit_wrapper( name = "fp_sincos_32_jit_wrapper", src = ":fp_sincos_32.opt.ir", jit_wrapper_args = { - "class_name": "fp_sincos_32", + "class_name": "FpSincos32", "namespace": "xls::fp", }, ) @@ -200,7 +200,7 @@ cc_xls_ir_jit_wrapper( name = "fp_trig_reduce_jit_wrapper", src = ":fp_trig_reduce.opt.ir", jit_wrapper_args = { - "class_name": "fp_trig_reduce", + "class_name": "FpTrigReduce", "namespace": "xls::fp", }, ) @@ -262,7 +262,7 @@ cc_xls_ir_jit_wrapper( name = "fpsqrt_32_jit_wrapper", src = ":fpsqrt_32.opt.ir", jit_wrapper_args = { - "class_name": "fpsqrt_32", + "class_name": "Fpsqrt32", "namespace": "xls::fp", }, ) diff --git a/xls/build_rules/tests/BUILD b/xls/build_rules/tests/BUILD index 6acfec8587..58aeec2944 100644 --- a/xls/build_rules/tests/BUILD +++ b/xls/build_rules/tests/BUILD @@ -494,7 +494,7 @@ cc_xls_ir_jit_wrapper( name = "chaining_example_opt_ir_jit_wrapper_double_cc", src = ":chaining_example_double_opt_ir.opt.ir", jit_wrapper_args = { - "class_name": "chaining_example", + "class_name": "ChainingExample", "function": get_mangled_ir_symbol("chaining_example", "double"), "namespace": "not_xls::test", }, diff --git a/xls/dslx/stdlib/BUILD b/xls/dslx/stdlib/BUILD index e0b8531154..1c3a91eba2 100644 --- a/xls/dslx/stdlib/BUILD +++ b/xls/dslx/stdlib/BUILD @@ -186,7 +186,7 @@ cc_xls_ir_jit_wrapper( name = "float32_add_jit_wrapper", src = ":float32_add.opt.ir", jit_wrapper_args = { - "class_name": "float32_add", + "class_name": "Float32Add", "namespace": "xls::fp", }, ) @@ -269,7 +269,7 @@ cc_xls_ir_jit_wrapper( name = "float32_mul_jit_wrapper", src = ":float32_mul.opt.ir", jit_wrapper_args = { - "class_name": "float32_mul", + "class_name": "Float32Mul", "namespace": "xls::fp", }, ) @@ -311,7 +311,7 @@ cc_xls_ir_jit_wrapper( name = "float32_upcast_jit_wrapper", src = ":float32_upcast.opt.ir", jit_wrapper_args = { - "class_name": "f32_to_f64", + "class_name": "F32ToF64", "namespace": "xls::fp", }, ) @@ -453,7 +453,7 @@ cc_xls_ir_jit_wrapper( name = "float32_fma_jit_wrapper", src = ":float32_fma.opt.ir", jit_wrapper_args = { - "class_name": "float32_fma", + "class_name": "Float32Fma", "namespace": "xls::fp", }, ) @@ -493,7 +493,7 @@ cc_xls_ir_jit_wrapper( name = "float32_ldexp_jit_wrapper", src = ":float32_ldexp.opt.ir", jit_wrapper_args = { - "class_name": "float32_ldexp", + "class_name": "Float32Ldexp", "namespace": "xls::fp", }, ) @@ -546,7 +546,7 @@ cc_xls_ir_jit_wrapper( name = "float32_fast_rsqrt_jit_wrapper", src = ":float32_fast_rsqrt.opt.ir", jit_wrapper_args = { - "class_name": "float32_fast_rsqrt", + "class_name": "Float32FastRsqrt", "namespace": "xls::fp", }, ) @@ -621,7 +621,7 @@ cc_xls_ir_jit_wrapper( name = "float64_add_jit_wrapper", src = ":float64_add.opt.ir", jit_wrapper_args = { - "class_name": "float64_add", + "class_name": "Float64Add", "namespace": "xls::fp", }, ) @@ -694,7 +694,7 @@ cc_xls_ir_jit_wrapper( name = "float64_mul_jit_wrapper", src = ":float64_mul.opt.ir", jit_wrapper_args = { - "class_name": "float64_mul", + "class_name": "Float64Mul", "namespace": "xls::fp", }, ) @@ -743,7 +743,7 @@ cc_xls_ir_jit_wrapper( name = "float64_fma_jit_wrapper", src = ":float64_fma.opt.ir", jit_wrapper_args = { - "class_name": "float64_fma", + "class_name": "Float64Fma", "namespace": "xls::fp", }, ) diff --git a/xls/examples/BUILD b/xls/examples/BUILD index 7ac83358ab..aea5528a3b 100644 --- a/xls/examples/BUILD +++ b/xls/examples/BUILD @@ -247,7 +247,7 @@ cc_xls_ir_jit_wrapper( name = "sha256_jit_wrapper", src = ":sha256.opt.ir", jit_wrapper_args = { - "class_name": "sha256", + "class_name": "Sha256", "function": "main", "namespace": "xls::examples", }, diff --git a/xls/examples/apfloat_add_parallel/BUILD b/xls/examples/apfloat_add_parallel/BUILD index e38c82b782..14fe146d5e 100644 --- a/xls/examples/apfloat_add_parallel/BUILD +++ b/xls/examples/apfloat_add_parallel/BUILD @@ -49,7 +49,7 @@ cc_xls_ir_jit_wrapper( name = "apfloat_add_parallel_jit_wrapper", src = ":apfloat_add_parallel.opt.ir", jit_wrapper_args = { - "class_name": "float32_add_se", + "class_name": "Float32AddSe", "namespace": "xls::examples", }, ) diff --git a/xls/examples/crc32/BUILD b/xls/examples/crc32/BUILD index 541e691a13..b42854fdcd 100644 --- a/xls/examples/crc32/BUILD +++ b/xls/examples/crc32/BUILD @@ -68,7 +68,7 @@ cc_xls_ir_jit_wrapper( name = "crc32_jit_wrapper", src = ":crc32.opt.ir", jit_wrapper_args = { - "class_name": "crc32", + "class_name": "Crc32", "namespace": "xls::examples", }, ) diff --git a/xls/examples/jpeg/BUILD b/xls/examples/jpeg/BUILD index 03dff4a30a..14b7816b31 100644 --- a/xls/examples/jpeg/BUILD +++ b/xls/examples/jpeg/BUILD @@ -175,7 +175,7 @@ cc_xls_ir_jit_wrapper( name = "idct_chen_jit_wrapper", src = ":idct_chen.opt.ir", jit_wrapper_args = { - "class_name": "idct_chen", + "class_name": "IdctChen", "namespace": "xls::jpeg", }, )