Analyzing statements with Procedures failed

[Matts966]

We instantiate Procedure like

    Procedure *proc = new Procedure(create_procedure_stmt->name_path(), create_procedure_stmt->signature());
    catalog->AddOwnedProcedure(proc);

and analyze statements with AnalyzeStatementFromParserAST.

AnalyzeStatementFromParserAST fails with something like

CREATE OR REPLACE PROCEDURE create_datawarehouse3()
BEGIN
  CREATE OR REPLACE TABLE datawarehouse3 AS
  SELECT
    x
  FROM
    dataset.main;
END;

create_datawarehouse3();
// -> 2022-03-27 15:33:25  FATAL  function_signature.cc : 496 : Check failed: kind == ARG_TYPE_FIXED == type != nullptr (1 vs. 0) 

Our workaround is patching like

diff --git zetasql/public/function_signature.cc zetasql/public/function_signature.cc
index bca4494..707ea2e 100644
--- zetasql/public/function_signature.cc
+++ zetasql/public/function_signature.cc
@@ -493,7 +493,6 @@ FunctionArgumentType::FunctionArgumentType(
       num_occurrences_(num_occurrences),
       type_(type),
       options_(options) {
-  ZETASQL_DCHECK_EQ(kind == ARG_TYPE_FIXED, type != nullptr);
 }

 FunctionArgumentType::FunctionArgumentType(SignatureArgumentKind kind,

for now.

Is there any better way to handle this issue?
For example, is ignoring runtime errors of *DCHECK* possible?

[jshute111]

It's hard to tell what's happening there, without a stack trace at least. It looks like an error constructing the FunctionSignature, before you get to constructing the Procedure. Running opt builds (rather than debug build) should skip the DCHECKs, but this check probably indicates some expected contract is being violated, so something else might go wrong later if you skip it. So I would look at what your code is doing that violates this, and see if it makes sense or can be changed to not violate it. (It is possible the check is overly strict and doesn't make sense.)

…

Message ID: ***@***.***>

[Matts966]

Thank you :) We use analyzer like below.

https://github.com/Matts966/alphasql/blob/883272aa9a9799cbdfa63cd97a5848ec66786ef8/alphasql/alphacheck.cc#L219

Input SQL example and error log is in #95 (comment), though it is without a stack trace.
The error indicate that kind is ARG_TYPE_FIXED, and type is nullptr.

[Matts966]

@jshute111
Also, I would like to ask how to run opt builds 🙇‍♂️
We setup ZetaSQL like below.
https://github.com/Matts966/alphasql/blob/883272aa9a9799cbdfa63cd97a5848ec66786ef8/WORKSPACE

[Matts966]

Found that bazel build -c opt enables opt builds, but DCHECK still triggered.

Matts966/alphasql#89