Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support bzlmod-based builds #11485

Open
4 of 7 tasks
coryan opened this issue May 3, 2023 · 9 comments
Open
4 of 7 tasks

Support bzlmod-based builds #11485

coryan opened this issue May 3, 2023 · 9 comments
Labels
cpp: operator Good things for the operator to fix type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@coryan
Copy link
Contributor

coryan commented May 3, 2023

Bazel is adding a new (better) way to handle dependencies:

https://bazel.build/external/overview#bzlmod

This automatically handles recursive dependencies, resolves diamond dependencies, etc. And supports multiple registries of packages:

https://bazel.build/external/registry

With a default "global registry":

https://github.com/bazelbuild/bazel-central-registry

We need to figure out a number of things, and implement a number of things. This list is probably not exhaustive, it needs to be filled out:

@coryan coryan added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. cpp: operator Good things for the operator to fix labels May 3, 2023
@coryan
Copy link
Contributor Author

coryan commented Aug 30, 2023

Waiting for Bazel 7.0

@alevenberg alevenberg self-assigned this Dec 11, 2023
@alevenberg
Copy link
Member

I'll take a stab at some of the tasks this week.

@alevenberg
Copy link
Member

The migration guide https://bazel.build/external/migration

@alevenberg
Copy link
Member

I think we're gonna first just want to compile with bazel 7.0, and then we can tackle bazelmod.

Waiting to see if we can get that build working on Mac (bazelbuild/bazel#20513) and Windows.

@alevenberg alevenberg removed their assignment Dec 13, 2023
@alevenberg
Copy link
Member

alevenberg commented Dec 13, 2023

FYI timeline for support for Bazel 6 is until December 2025

@coryan
Copy link
Contributor Author

coryan commented Dec 13, 2023

Yes, but the support policy for the libraries is only 6 months:

https://opensource.google/documentation/policies/cplusplus-support#support_criteria_3

I will argue that we should only start the clock on Bazel 6 once Bazel 7 works.

@scotthart
Copy link
Member

Add this to 2024 planning.

@mering
Copy link
Contributor

mering commented Aug 19, 2024

As there is a working MODULE.bazel file already, I would appreciate this being available in BCR. The first uploads could be manually while future ones could be more automated. Do you plan on adding it yourself or should I go ahead an propose a first upload to BCR?

@scotthart
Copy link
Member

We're still waiting on several of our dependencies to be added to BCR. The Bazel team is aware of this and is working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp: operator Good things for the operator to fix type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

4 participants