Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve TS #2026

Open
Gsiete opened this issue Mar 21, 2024 · 1 comment
Open

Improve TS #2026

Gsiete opened this issue Mar 21, 2024 · 1 comment
Assignees
@tom-andersen
Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@Gsiete
Copy link

Gsiete commented Mar 21, 2024

To avoid people like me from spending a long time trying to understand why this fails, this line could be changed from
precondition?: Precondition
to
precondition?: Omit<Precondition, 'exists'>

https://github.com/googleapis/nodejs-firestore/blob/319adc3ff6fdcd0ab61766d4eb8301fc8ac5431b/types/firestore.d.ts#L1469C22-L1469C34
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/nodejs-firestore API. label Mar 21, 2024
@tom-andersen tom-andersen self-assigned this Mar 21, 2024
@tom-andersen tom-andersen added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Mar 21, 2024
@tom-andersen
Copy link
Contributor

Thank you for the suggestions. I will bring this up for team discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tom-andersen tom-andersen

Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Gsiete @tom-andersen