Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: sort document reference by long type id #2257

Merged
merged 7 commits into from
Dec 17, 2024

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Dec 6, 2024

Document ID supports strings and well as long integers in the format of "id" . When sorting documents by document ID, it should be sorted in the following order:

  1. Long (numeric order)
  2. String (lexicographic order)

@milaGGL milaGGL requested review from a team as code owners December 6, 2024 21:41
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Dec 6, 2024
Copy link

conventional-commit-lint-gcf bot commented Dec 6, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/nodejs-firestore API. label Dec 6, 2024
@milaGGL milaGGL self-assigned this Dec 6, 2024
@milaGGL milaGGL assigned ehsannas and unassigned milaGGL Dec 6, 2024
@milaGGL milaGGL requested a review from ehsannas December 6, 2024 22:11
@milaGGL milaGGL added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 6, 2024
@milaGGL milaGGL removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 9, 2024
@milaGGL milaGGL added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 10, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 10, 2024
dev/src/path.ts Outdated Show resolved Hide resolved
@ehsannas ehsannas assigned milaGGL and unassigned ehsannas Dec 11, 2024
@milaGGL milaGGL requested a review from ehsannas December 12, 2024 20:11
dev/src/path.ts Outdated Show resolved Hide resolved
@milaGGL milaGGL added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 16, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 16, 2024
@milaGGL milaGGL merged commit 3fd0de9 into main Dec 17, 2024
17 checks passed
@milaGGL milaGGL deleted the mila/fix-sdk-sort-document-reference-bug branch December 17, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants