Skip to content
This repository has been archived by the owner on Feb 2, 2021. It is now read-only.

jQuery UI Sortable + Caja issue #1949

Open
kpreid opened this issue Apr 16, 2015 · 1 comment
Open

jQuery UI Sortable + Caja issue #1949

kpreid opened this issue Apr 16, 2015 · 1 comment

Comments

@kpreid
Copy link
Contributor

kpreid commented Apr 16, 2015

Original issue 1951 created by [email protected] on 2015-01-16T14:05:14.000Z:

What revision of the cajoler exhibits the problem? On what browser and OS?
Rev 5707 built on 2014-12-18 14:13:43
Firefox 34.0
Windows 7

What steps will reproduce the problem?

  1. Go to http://jqueryui.com/sortable/#display-grid
  2. Click view source, copy, goto playground
  3. Paste and Cajole

What is the expected output? What do you see instead?
The expected output would be the same as the example on
http://jqueryui.com/sortable/#display-grid.

The sorting is not working properly, there seems to be some offset or something.

Please provide any additional information below.
"Sortable" code from http://jqueryui.com/sortable/#display-grid at the time of error:

<!doctype html>
<html lang="en">
<head>
<meta charset="utf-8">
<title>jQuery UI Sortable - Display as grid</title>
<link rel="stylesheet" href="//code.jquery.com/ui/1.11.2/themes/smoothness/jquery-ui.css">
<script src="//code.jquery.com/jquery-1.10.2.js"></script>
<script src="//code.jquery.com/ui/1.11.2/jquery-ui.js"></script>
<link rel="stylesheet" href="/resources/demos/style.css">
<style>

sortable { list-style-type: none; margin: 0; padding: 0; width: 450px; }

sortable li { margin: 3px 3px 3px 0; padding: 1px; float: left; width: 100px; height: 90px; font-size: 4em; text-align: center; }

</style>
<script>
$(function() {
$( "#sortable" ).sortable();
$( "#sortable" ).disableSelection();
});
</script>
</head>
<body>
<ul id="sortable">
<li class="ui-state-default">1</li>
<li class="ui-state-default">2</li>
<li class="ui-state-default">3</li>
<li class="ui-state-default">4</li>
<li class="ui-state-default">5</li>
<li class="ui-state-default">6</li>
<li class="ui-state-default">7</li>
<li class="ui-state-default">8</li>
<li class="ui-state-default">9</li>
<li class="ui-state-default">10</li>
<li class="ui-state-default">11</li>
<li class="ui-state-default">12</li>
</ul>
</body>
</html>

@mbucur
Copy link

mbucur commented May 23, 2016

I'm seeing this warning in the console:

Domado: HTMLLIElement is not tamed; its specific properties/methods will not be available on li

Perhaps we need to tame the underlying class for the li tag to make this work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants