Skip to content
This repository has been archived by the owner on Dec 15, 2020. It is now read-only.

Edit Crop start-end Times doesn’t show the current times where sliders are placed #47

Open
garrettmurray opened this issue May 2, 2019 · 0 comments
Open

Edit Crop start-end Times doesn’t show the current times where sliders are placed #47

garrettmurray opened this issue May 2, 2019 · 0 comments
Assignees
@garrettmurray
Labels
bug Something isn't working

Comments

@garrettmurray
Copy link
Contributor

Actions Performed

  1. Open science journal app
  2. Open any experiment with trial
  3. Click on trial to view trial review screen
  4. Click on menu more options and click ‘Crop’
  5. Place the start and end time sliders at desired points and note the start time and end time.
  6. Click Crop menu and observe time fields shown in Edit start time and edit end time dialogues

Expected Result
Time fields in edit start time and end time show the current time points where the Crop sliders are placed currently at

Actual Result
Time fields in edit start time and end time show default values instead of current slider positions

Comment:
Edit Start and End time does not display the current time in the popup and instead only displays the initial start time and does not display the updated or changed timings. This is reproducible only in iphones 5s/OS 12.1 and ipad 5th Gen/OS 12.1

Reproducibility
5/5

Device / OS
iPhone 6/11.2
@garrettmurray garrettmurray added the bug Something isn't working label May 2, 2019
@garrettmurray garrettmurray self-assigned this May 2, 2019
marcisme added a commit to marcisme/science-journal-ios that referenced this issue May 3, 2019
@marcisme
Ensure crop points are current
13eeae1 
Previously setting the crop points via the text entry dialog would
update the sliders, but moving the sliders would not update the
pre-populated values in the text entry dialog. This was due to the text
field being populated with the `Trial` values, which aren't updated
until the crop changes are saved. This change uses the crop values from
the current playback view controller, which is the same value that the
sliders present and modify.

Fixes googlearchive#47
@marcisme marcisme mentioned this issue May 3, 2019
Closed
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@garrettmurray garrettmurray

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure crop points are current marcisme/science-journal-ios
1 participant
@garrettmurray