Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out of range XTRA value in one of the avar2 mappings #13

Open
Lorp opened this issue Jun 9, 2024 · 2 comments
Open

Out of range XTRA value in one of the avar2 mappings #13

Lorp opened this issue Jun 9, 2024 · 2 comments

Comments

@Lorp
Copy link
Collaborator

Lorp commented Jun 9, 2024

The Fencer tool picks up an out of range error for XTRA in one of the mappings in this designspace file, line 230:

https://github.com/googlefonts/amstelvar-avar2/blob/main/Sources/Roman/AmstelvarA2-Roman_avar2.designspace

Editing the 72 to 73 (=XTRA min) avoids the error and allows all 29 mappings to be pasted into Fencer.

BTW there’s also a Named Instance with XTRA=72 which should also be fixed, line 2811.

(Arguably Fencer should issue a warning, clamp the value, and proceed. I assume fontmake clamps when running the variation solver on mappings data.)

@gferreira2
Copy link
Contributor

thank you. I will fix it asap!

@gferreira2
Copy link
Contributor

fixed in aa6e806

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants