-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSRV #1019
Comments
I think it's fine to say 1.76 for now, and I would not place much value on trying to maintain a low MSRV for the foreseeable future; that is, if something in a new rust release is useful I'm happy for us to adopt it. |
Pragmatically it's the lowest of google3 and Chrome. I'm not sure that is
published in a form we could readily republish or consume in CI (which
would be nice to do at some point).
…On Tue, Jul 23, 2024, 1:30 PM Colin Rofls ***@***.***> wrote:
I think it's fine to say 1.76 for now, and I would not place much value on
trying to maintain a low MSRV for the foreseeable future; that is, if
something in a new rust release is useful I'm happy for us to adopt it.
—
Reply to this email directly, view it on GitHub
<#1019 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABRKXAGRMKGEAK5OTSC5TBLZN2AKPAVCNFSM6AAAAABLKXVDDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBVG4YDINZZGY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Do you know offhand what that value is? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the desired MSRV for this family of crates?
Right now, it is 1.76 to get a build. This is because tests within
int-set
importstd::hash::DefaultHasher
which is a new location for it. Prior to 1.76, it was available asstd::collections::hash_map::DefaultHasher
.If that's addressed, then the MSRV is 1.75 because code within
int-set
uses the features described here: rust-lang/rust#91611The text was updated successfully, but these errors were encountered: