Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement tree shaking for glyphs #270

Open
rsheeter opened this issue Apr 20, 2023 · 2 comments
Open

Implement tree shaking for glyphs #270

rsheeter opened this issue Apr 20, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@rsheeter
Copy link
Contributor

As noted at #268 (comment), flattened components may result in unreachable glyphs. We should drop them, or at least have an option to drop them.
@rsheeter rsheeter mentioned this issue Apr 20, 2023
Merged
@anthrotype
Copy link
Member

funny that you mention skipExportGlyphs.. the way that lib key is implemented in ufo2ft (at the very beginning, as the prepropcessor obtains the glyph set to work on from the source, before any filter such as FlattenComponents is run) makes it such that it is not a viable workaround for getting rid of those glyphs that become unreachable as result of the flattening operation...

that issue came up recently in ufo2ft googlefonts/ufo2ft#692

@rsheeter
Copy link
Contributor Author

Ty, updating description.

@rsheeter rsheeter changed the title Implement skipExportedGlyphs Implement tree shaking for glyphs Apr 20, 2023
@rsheeter rsheeter added the enhancement New feature or request label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rsheeter @anthrotype