Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outline incompatibilities introduced later in the pipeline are not fatal #1091

Open
Hoolean opened this issue May 10, 2024 · 1 comment
Open

Comments

@Hoolean
Copy link

Hoolean commented May 10, 2024

Earlier we encountered #897 as cu2qu raised a fatal error, however, when debugging the issue we tested with and without cu2qu and noticed that when cu2qu is disabled then the font build completes with an incomplete gvar table.

This happens as varLib skips glyphs with incompatible outlines with a warning but not a fatal error; the compatibility checker is run at the beginning of the pipeline and so also cannot detect such issues.

For projects with quadratic sources it would be nice to disable cu2qu but keep the same level of strictness. Should we make the above warning fatal by default (perhaps only for fontmake)?

@anthrotype
Copy link
Member

yeah, not the first time that this varLib's warning-that-should-have-been-an-error let some bug slip..
Maybe we could add a new fontTools.config option to turn that into an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants