Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content padding is not used for initial rendering #326

Closed
kkris opened this issue Jun 12, 2023 · 2 comments · Fixed by #327
Closed

Content padding is not used for initial rendering #326

kkris opened this issue Jun 12, 2023 · 2 comments · Fixed by #327
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. released type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@kkris
Copy link
Contributor

kkris commented Jun 12, 2023

When you set the contentPadding parameter, it is not considered when the map is initially rendered. This results in cameraPositionState.position being off-center. Subsequent updates will correctly center taking the content padding into account.

I created a simple reproducing example here: kkris@865bd3c

Here is a video of this bug: https://github.com/googlemaps/android-maps-compose/assets/232214/ed5b164f-d926-4ca7-afdb-ffb14f3fe4e1
@kkris kkris added triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 12, 2023
@wangela
Copy link
Member

wangela commented Jun 12, 2023

If you would like to upvote the priority of this issue, please comment below or react with 👍 so we can see what is popular when we triage.

@kkris Thank you for opening this issue. 🙏
Please check out these other resources that might help you get to a resolution in the meantime:

This is an automated message, feel free to ignore.

kkris added a commit to kkris/android-maps-compose that referenced this issue Jun 12, 2023
@kkris
fix: Set initial map padding (googlemaps#326)
951ea34
@kkris kkris mentioned this issue Jun 12, 2023
Merged
@kikoso kikoso added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed triage me I really want to be triaged. labels Jul 10, 2023
kkris added a commit to kkris/android-maps-compose that referenced this issue Aug 1, 2023
@kkris
fix: Set initial map padding (googlemaps#326)
ae012d1
bubenheimer added a commit to bubenheimer/android-maps-compose that referenced this issue Dec 16, 2023
@bubenheimer
Use recomposed map listener callbacks rather than only the initially …
8348662 
…composed version

Fixes googlemaps#326
@bubenheimer bubenheimer mentioned this issue Dec 16, 2023
Merged
4 tasks
kkris added a commit to kkris/android-maps-compose that referenced this issue Oct 18, 2024
@kkris
fix: Set initial map padding (googlemaps#326)
ba8719d
dkhawk pushed a commit that referenced this issue Oct 29, 2024
@kkris
chore: Set initial map padding (#326) (#327)
e9df1cf
@googlemaps-bot
Copy link
Contributor

🎉 This issue has been resolved in version 6.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. released type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Set initial map padding (#326) kkris/android-maps-compose
4 participants
@kkris @kikoso @wangela @googlemaps-bot