From 1dc768e48ba8bc7995890f2821c04680e068cccc Mon Sep 17 00:00:00 2001 From: "Chris J. Shull" Date: Tue, 14 May 2024 11:03:31 -0700 Subject: [PATCH 1/4] add "maps" to libraries --- samples/web-components-map/web-components-map.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/samples/web-components-map/web-components-map.json b/samples/web-components-map/web-components-map.json index 4679b7ffdd..5dff7b8bb4 100644 --- a/samples/web-components-map/web-components-map.json +++ b/samples/web-components-map/web-components-map.json @@ -1,7 +1,7 @@ { "title": "Add a Map using HTML", "callback": "initMap", - "libraries": [], + "libraries": ["maps"], "version": "beta", "tag": "web_components_map", "name": "web-components-map", @@ -11,4 +11,4 @@ "alias": "mode" }, "permalink": "samples/{{ page.fileSlug }}/{{mode}}/{% if mode == 'jsfiddle' %}demo{% else %}index{% endif %}.{{ page.outputFileExtension }}" - } \ No newline at end of file + } From da366c01ab94d6345907f8253655880d503cf509 Mon Sep 17 00:00:00 2001 From: "Chris J. Shull" Date: Tue, 14 May 2024 11:05:01 -0700 Subject: [PATCH 2/4] Update style.scss to remove redundant styles --- samples/web-components-markers/style.scss | 4 ---- 1 file changed, 4 deletions(-) diff --git a/samples/web-components-markers/style.scss b/samples/web-components-markers/style.scss index 37af5c7d4e..60a64e9dfc 100644 --- a/samples/web-components-markers/style.scss +++ b/samples/web-components-markers/style.scss @@ -9,8 +9,4 @@ /* [START maps_web_components_markers] */ @include meta.load-css("../../shared/scss/default.scss"); - gmp-map { - height: 400px; - } - /* [END maps_web_components_markers] */ From 62b48f0ab2a39bc9ec9d84fe7b91fa620ec4e69c Mon Sep 17 00:00:00 2001 From: "Chris J. Shull" Date: Tue, 14 May 2024 11:05:37 -0700 Subject: [PATCH 3/4] remove unneeded map-id="DEMO_MAP_ID" --- samples/web-components-map/index.njk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/samples/web-components-map/index.njk b/samples/web-components-map/index.njk index dae9b54b4f..8557e3dfb4 100644 --- a/samples/web-components-map/index.njk +++ b/samples/web-components-map/index.njk @@ -6,6 +6,6 @@ --> {% extends '../../src/_includes/layout.njk'%} {% block html %} - + {% endblock %} From e7656a04b777bd3dab91633e0288f3b5ea5be6f4 Mon Sep 17 00:00:00 2001 From: "Chris J. Shull" Date: Tue, 14 May 2024 11:06:23 -0700 Subject: [PATCH 4/4] Update web-components-markers.json to add maps library --- samples/web-components-markers/web-components-markers.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/samples/web-components-markers/web-components-markers.json b/samples/web-components-markers/web-components-markers.json index 90bcace208..489cb5ba90 100644 --- a/samples/web-components-markers/web-components-markers.json +++ b/samples/web-components-markers/web-components-markers.json @@ -1,7 +1,7 @@ { "title": "Add a Map with Markers using HTML", "callback": "initMap", - "libraries": ["marker"], + "libraries": ["maps", "marker"], "version": "beta", "tag": "web_components_markers", "name": "web-components-markers", @@ -11,4 +11,4 @@ "alias": "mode" }, "permalink": "samples/{{ page.fileSlug }}/{{mode}}/{% if mode == 'jsfiddle' %}demo{% else %}index{% endif %}.{{ page.outputFileExtension }}" - } \ No newline at end of file + }