Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add terminate cli argument for shell-command. #319

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hayd
Copy link

@hayd hayd commented Jun 2, 2015

If a new event occurs whilst the current one is still in progress, it
terminates the Popen and runs the command anew.

If a new event occurs whilst the current one is still in progress, it
terminates the Popen and runs the command anew.
@hayd
Copy link
Author

hayd commented Jun 2, 2015

I think .terminate is sufficient, at least for my work.

Perhaps there is a need for more (hence the sledgehammer comment), specifically AutoRestart.Trick.stop does some magic to kill all spawned tasks (presumably terminate doesn't do this)?

@hadrien hadrien mentioned this pull request Oct 5, 2022
@hadrien
Copy link

hadrien commented Oct 5, 2022

👋🏽 I want this! How can I help having this merged?

@BoboTiG
Copy link
Collaborator

BoboTiG commented Oct 5, 2022

👋🏽 I want this! How can I help having this merged?

Any help would be great!
FTR the PR needs to be rebased on the up-to-date master branch, add at least one test, and a changelog line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants