Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] OpenTelemetry Instrumentation #257

Open
1 task done
jwafle opened this issue Jul 22, 2024 · 2 comments
Open
1 task done

[FEATURE] OpenTelemetry Instrumentation #257

jwafle opened this issue Jul 22, 2024 · 2 comments

Comments

@jwafle
Copy link

jwafle commented Jul 22, 2024

Is there an existing feature request for this?

  • I have searched the existing feature requests

Is your feature request related to a problem? Please describe.

OpenTelemetry is becoming a popular open-source solution for monitoring application performance. Well-defined semantic conventions are supplied for HTTP metrics and traces. See here: https://opentelemetry.io/docs/specs/semconv/http/

In following with their guidance on instrumentation, they recommend implementing instrumentation code in the library for which it is written: https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/instrumentation#new-instrumentation

Describe the solution that you would like.

If interested, I would be willing to contribute instrumentation code that implements OpenTelemetry metrics and tracing as a middleware for mux. Please let me know if you would like me to proceed with opening a PR.

Describe alternatives you have considered.

I have opened an issue to explore updating the current otelmux instrumentation: open-telemetry/opentelemetry-go-contrib#5936

However, current guidance from OpenTelemetry is to seek to include instrumentation with the libraries/packages themselves, thus why I am opening this issue.

Anything else?

No response

@AlexVulaj
Copy link
Member

Hey @jwafle - I think this would be a wonderful thing to add to the library. You have my support to go ahead with a PR for this.

@jwafle
Copy link
Author

jwafle commented Aug 15, 2024

Hey @jwafle - I think this would be a wonderful thing to add to the library. You have my support to go ahead with a PR for this.

Great! I'll work on opening a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants